https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31109

--- Comment #28 from David Cook <[email protected]> ---
Comment on attachment 167494
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167494
Bug 31109: Prevent overwriting bibliographic records in case of simultaneous
modification

Review of attachment 167494:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=31109&attachment=167494)
-----------------------------------------------------------------

::: C4/Biblio.pm
@@ +116,4 @@
>  use Koha::SimpleMARC;
>  use Koha::Libraries;
>  use Koha::Util::MARC;
> +use Koha::Util::Misc qw( digest );

You're still using the Exporter.

Rather than using the Exporter in Koha::Util::Misc, you have a couple options.

1. You could make an object like Koha::Util::Digester, which you then
instantiate and then call a method upon (e.g. $digester->digest($rec)). Of
course, keep in mind that I think Koha::Util::Misc is unnecessary and should be
replaced with Digest::MD5 anyway.

2. Just call the function fully qualified down below (e.g.
Koha::Util::Misc::digest($rec) ).

::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
@@ +905,4 @@
>                              </form>
>                          </div> <!-- /.dialog.alert -->
>                      [% END # /IF duplicatebiblionumber %]
> +

Adds unnecessary whitespace. Not a dealbreaker but we typically avoid
unnecessary whitespace changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to