https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36027

Julian Maurice <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #20 from Julian Maurice <[email protected]> ---
If I use at least one --check-* option, all --skip-* options are ignored, which
make sense given that when a --check-* option is used all other checks are
disabled. But this is not documented.
And it would be nice to have a warning when using --skip-* and --check-*
options together.

The code can be improved too. For instance:

  CheckItemsBranch() if $options{'check-branch'} || $options{'skip-branch'};

is not easy to understand ($options{skip-branch} == 1 means "do not skip" which
is confusing)

Failing QA for lack of documentation and also for what Martin said in comment
19 (more detailed commit message, including a test plan)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to