https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681

--- Comment #55 from David Cook <[email protected]> ---
I was thinking how this doesn't fit with the "PERL14: Exports" and "PERL15:
Object-oriented code and the Koha:: namespace" coding guidelines.

I suppose an argument could be made that this is one of the exceptions
indicated in the guidelines, but it probably could've been done like this:

my $output = Koha::Installer::Output->new();
$output->success($out,"Test");

With the $output just being created at the top of the "up" sub. 

Too late now but just a thought.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to