https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36128

--- Comment #3 from Denys Konovalov <[email protected]> ---
(In reply to Phil Ringnalda from comment #2)
> You're going to get tripped up by
> https://wiki.koha-community.org/wiki/Commit_messages (and then probably
> later by the project usually not being fond of adding checks for things
> being undefined when they shouldn't be)
> 
> And when you get to the part about writing a test plan, it looks to me like
> the test plan is going to look like:
> 
> 1. Go to Tools - Overdue notice/status triggers and verify that for every
> single patron type for both Default and every individual library, you have
> no value set for Delay, so that you will never send anyone an overdue notice
> 2. Run the cron job which creates and sends overdue notices
> 
> which seems like rather odd behavior. If you don't want to send notices,
> wouldn't it be better to comment out the line in /etc/cron.daily/koha-common
> that runs the overdue notices job? Or if you really want to be able to send
> them later without anyone having to remember to uncomment the job, maybe
> just add an unused patron type and set a notice delay for that one patron
> type?

I understand your doubts, however after fixing this, the cron job returns much
more helpful error messages about overdue rules not being configured correctly:

/etc/cron.daily/koha-common:
No branches with active overduerules at
/usr/share/koha/bin/cronjobs/overdue_notices.pl line 365.
bibliothek: 11 status returned by
"/usr/share/koha/bin/cronjobs/overdue_notices.pl -t"

Thus I think that this fix will at least help when you to find the cause of the
crob error messages instead of giving you a file and a LOC.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to