https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29087
Marcel de Rooy <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|[email protected] |[email protected] |y.org | Status|Signed Off |Failed QA --- Comment #27 from Marcel de Rooy <[email protected]> --- - my @hold_not_allowed_itypes = Koha::CirculationRules->search( + my $default_rule = Koha::CirculationRules->get_effective_rule( { rule_name => 'holdallowed', - branchcode => undef, - categorycode => undef, rule_value => 'not_allowed', } - )->get_column('itemtype'); + ); Shouldnt you look here for branch undef, category undef AND itemtype undef ? Than you know that there is a 'real' default rule that does not allow holds. If there is no such default rule but there is one itemtype with not_allowed, the if default_rule branch may calculate incorrectly? It would get all itemtypes and subtract the ones which have an allowed rule, but they may not be present since you only reject one itemtype.. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
