https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919
--- Comment #19 from Matt Blenkinsop <[email protected]> --- (In reply to Nick Clemens (kidclamp) from comment #16) > While this does allow for retaining original lost status when marking an > item claims returned, it doesn't allow staff to see the return claim beyond > the patrons checkout page. > > On the details page: > We show only the Lost status - we need to alert if there is a claim as well Done > On the items tab: > We show only the lost status - we need to alert if there is a claim as well Done > For items in the claimed return status, I cannot change the lost value > For items with a claim and another lost status, I can alter the lost status > We need to reconcile this behavior The default behaviour currently is that you can't change the lost status if there is a return claim. I've changed this so you can now change it even when a return claim exists. The alerts above will be visible to show the return claim if it the status is changed > > This feels a bit like a bandaid - can you elaborate on the other options > that made this worse?I am not blocking, but I think displaying the claim if > not reflected in the lost status would be a requirement here. I initially started down the process of completely stripping the return claims feature out of the lost status entirely and using a method to check for both lost status and any return claims to determine the item status. That became incredibly complicated as there are 100s of instances of 'itemlost' that would need refactoring to now use this logic and would probably introduce technical debt as most community devs might not be aware of this new method when writing code down the line. Amending how return claims govern the lost status seemed like the best method to allow the two to co-exist without completely re-writing the entire concept. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
