https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33363
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer <[email protected]> --- Hi Kyle, some quick explanations to keep this going: (In reply to Kyle M Hall from comment #20) > (In reply to Katrin Fischer from comment #19) > > Some small stuff, please follow-up: > > > > 1) Database update > > > > It's not using say_success, but it's also not giving us any success message > > :) > > Done Thanks! > > > > > 2) What is actually meant by "manage"? > > > > I assume that "manage" actually means "edit". While any of the permissions > > allow to "view". > > > > If that is the case, I feel it would be good to adjust the permission > > descriptions accordingly. > > That was the pre-existing term and in Koha we've always used it as a > catch-all for anything not covered by more specific permissions. It covers > more than just viewing, such as approvals. We have used it as a catch all, I agree, it meant: CRUD. But now that we are starting to split permissions up, I think we should try to be as precise in our descriptions as possible. For example: manage so far included deleting, but it does no longer. What do you think about "View and edit ..." as a description to replace "Manage..." (not renaming permission code, but permission description) > > There is a slight discrepancy tho: > > With only create permission, I have the entry to suggestions in the "more" > > menu, but it's missing from the navigation in the acquisition module. > > Can you add a screenshot or be more specific about where this pulldown is? The "More" in the main navigation of Koha on top of every page :) I think it should probably be visible with "any" suggestion permission, what do you think? The same for the acquisition module navigation on the left. > > I can also not see the pending suggestions on the start page. > > That is intended. A librarian that can only create suggestions has no need > to see the suggestions that need managed. > > > I think we should adjust the navigation in the acq module at least. see above > > Should the pending suggestions on acq and staff interface home page be > > visible with manage_suggestions only or also with any suggestion > > permission? > > They should be visible only for manage_suggestions. OK, so we leave the pending suggestions display for the "manage" permission. > > > > > 3) Question > > > > + <div class="note">Only staff with superlibrarian or full > > suggestions permissions are returned in the search results</div> > > > > I think this is in line with the previous behavior, but I wonder if we > > should not change to allow "any" instead of "full" here. > > I disagree. This is still a limit for just librarians that manage > permissions, just like all the other manage permissions we can limit patron > searches too. > > > > > I assume this is for setting the manager of a suggestion - editing might be > > required, but not sure if delete and create would be as well. > > They would not be. But if the search is limited to must have "all module" permissions, I cannot edit someone that has only manage or only delete or only create to be a manager. I think the "only manage" could maybe be a use case? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
