https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35959
--- Comment #59 from Jonathan Druart <[email protected]> --- (In reply to Julian Maurice from comment #58) > (In reply to Jonathan Druart from comment #57) > > If we are starting that, we should put and write down where our limits are. > > Otherwise people are going to do that everywhere... > Ok, let me try: > > > PERLXX: Prefer "use" than "require" > > > > "use" is the preferred method of importing Perl modules. You should always > > use "use" when possible. > > All "use" statements should appear at the top of the file. > > > > "require" is allowed when "use" cannot be used or when it causes problems. > > Allowed uses of "require" include: > > - Loading modules whose name is known only at runtime (for instance, > > plugins) > > - Fixing circular dependency problems (aka "Inconsistent hierarchy during > > C3 merge") > > > > If you think you need to use "require" for something that is not in the > > list above, please contact a QA team member first to confirm it's OK. Thanks, excellent! I didn't notice you actually got rid of all of them. > I would add to the list that "making a script run faster" or "making a > script use less memory" can also be valid uses. But it really depends on how > much we gain VS how much modifications are required, so I would let that to > QA judgement. Yes, and this is when it's hard to decide. For instance: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158003 This patch exists only because C4::Context is badly written... -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
