https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36672

Andrii Nugged <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #9 from Andrii Nugged <[email protected]> ---
IMO We have a bug when elements with "All" (*) don't shown for the user and
even die with a 500 error:


Because smart-rules.tt have this removed:

-    [% SET c = '*' UNLESS c.defined AND c != '' %]

      ...

-        [% SET i = '*' UNLESS i.defined AND i != '' %]


this makes wrong logic in 

    [% IF i == '*' %]
        <em>All</em>
and

    [% IF c == '*' %]
        <em>All</em>



If to return lines after "SET waiting_hold_cancellation..":

     [% SET waiting_hold_cancellation =
all_rules.$c.$i.waiting_hold_cancellation %]

+    [% SET c = '*' UNLESS c.defined AND c != '' %]
+    [% SET i = '*' UNLESS i.defined AND i != '' %]

     [% IF ( waiting_hold_cancellation.defined && waiting_hold_cancellation !=
'' ) %]


It works normally, ... but I just did the preliminary test, so I suspect it.
I will test more.


But maybe my insight will give the authors a hint, and this can be confirmed
faster (I am now in the middle of the travel).

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to