https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32722
Mathieu Saby <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #16 from Mathieu Saby <[email protected]> --- For UNIMARC, your patch is fixing our problems, except this little issue: - add data in 410$t (mandatory subfield in non mandatory field) - click on save - during 1 or 2 seconds, all the 4XX$t are colored in yellow, with no reason - but the record is saved I believe it can be fixed in a follow-up, so I add myt sign-off. BUT I cannot tell if your patch will cause problems to MARC21 installations, because I don't know well this format. Should the patch be tested and signed off also by a a member of MARC21 community ? ======================== Here is my test plan : **** Before patch : - Impossible to create a record without filling mandatory subfields in non mandatory fields Ex : create a new record with only the value "test" in 200$a Error message : "The following mandatory subfields aren't filled: Tag 020 subfield a Country Code in tab 0 Tag 021 subfield a Country Code in tab 0 etc" - Impossible to edit existing record without filling mandatory subfields in non mandatory fields Ex : - Identify a non mandatory subfield in a non mandatory field (for ex, 856$u) - Find a record with no value at all in this field - Edit the framework to make the subfield (but not the field) mandatory - Try to edit the record and to save it => Impossible, with this message : "The following mandatory subfields aren't filled:Tag 856 subfield u " **** After patch : - Identify a non mandatory subfield in a non mandatory field (for ex, 856$u) - Find a record with no value at all in this field - Edit the framework to make the subfield (but not the field) mandatory - Try to edit the record and to save it => possible, without alert Other tests : - Add data in non mandatory subfield of non mandatory field (205$a) => possible - Add data in non mandatory subfield of mandatory field (200$i) => possible - Delete data in non mandatory subfield of non mandatory field (210$c) => possible - Delete data in non mandatory subfield of mandatory field (200$f) => possible - Change data in mandatory subfield of mandatory field (200$a) => possible - Change data in mandatory subfield of non mandatory field (410$t) => possible - Delete a subfield of mandatory field but keeping the other subfields (810$b) => save - Delete all subfields of mandatory field (810$b) => impossible to save : "The following mandatory subfields aren't filled: The following fields aren't filled: Field 801 is mandatory, at least one of its subfields must be filled. " - Delete a mandatory subfield of a mandatory field (210$a) => impossible to save : "The following mandatory subfields aren't filled: Tag 200 subfield a Title Proper in tab 2 " - Add data in non mandatory subfield of non mandatory field (942$2) , but keeping blank the mandatory subfield (942$c) => impossible to save : "The following mandatory subfields aren't filled:Tag 942 subfield c Koha item type in tab 9 " -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
