https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36027
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement updates release notes| |the data inconsistencies | |script | |(misc/maintenance/search_fo | |r_data_inconsistencies.pl) | |so that you can optionally | |run specific checks, rather | |than running all the checks | |at the same time. | | | |Examples: | |- Run all checks | |(no change): | |misc/maintenance/search_for | |_data_inconsistencies.pl | |- | |Run checks for item type | |issues and patrons with an | |invalid age for their | |category: | |misc/maintenance/search_for | |_data_inconsistencies.pl | |--check-status --check-age | |- Skip specific checks, but | |run all the others: | |misc/maintenance/search_for | |_data_inconsistencies.pl | |--skip-status --skip-title | | | |Use | |misc/maintenance/search_for | |_data_inconsistencies.pl | |--help for all the check | |and skip options. Severity|normal |enhancement --- Comment #25 from David Nind <[email protected]> --- Thanks Alexandre for the patch. I've signed this off, as it does what it says it will do. I have made some comments. I will leave it up to you (or the QA Team) to decide if these need addressing. I think this is an enhancement, rather than fixing something that is wrong. So I have changed the status. I have also added a draft release note. Testing notes (using koha-testing-docker (KTD)): 1. Set up data so there are inconsistencies: 1.1 There is already one inconsistency in the sample data, for record 369 (encoding errors) 1.2 I created an inconsistency for patron age and patron category type: . koha-mysql kohadev . update borrowers set categorycode = "K" where borrowernumber=49; 2. Step 3, ran check with: misc/maintenance/search_for_data_inconsistencies.pl --check-status --check-age 3. Step 4, ran check with: misc/maintenance/search_for_data_inconsistencies.pl --skip-status 4. Step 5, ran check with: misc/maintenance/search_for_data_inconsistencies.pl --check-age --skip-status Some comments: 1. The check-status option includes checking for item type issues (as described in the help description), but it also checks for invalid MARCXML. I think that the MARCXML check should have its own option (--check-marcxml Check for invalid MARCXML in bibliographic records). 1.1 I'm not sure how hard this to do (I am not a developer). 1.2 I'm not sure whether there are other checks in the script that are not included in the description and have their own options. 1.2 Instead of --check-status, --check-itemtype 2. Instead of --check-branch, use --check-library. While branch is used in the underlying code, the terminology guidelines suggest we should use library. (https://wiki.koha-community.org/wiki/Terminology#L) 3. Warning when you use --check-* and --skip-* options in the same command (step 5). I've made a wording change suggestion. The current text says to me that if you use skip and check options in the same command, the skip options are ignored. That is, it will ignore/not run the skip options: . Current warning: "Warning : skip options are ignored when check options are provided" . Suggested warning: "Warning: The --skip-* option(s) were ignored. Only the --check-* options in the command were run." 4. Description and help text. I think this needs some work with formatting and the text. I would be happy to add a follow-up patch with some suggested changes. 5. The QA script has warnings (to run the QA script when using koha-testing-docker): qa WARN misc/maintenance/search_for_data_inconsistencies.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 83, now: 206) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
