https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560

--- Comment #39 from Martin Renvoize <[email protected]> ---
(In reply to Katrin Fischer from comment #37)
> FOR THIS PATCH SET:
> 
> 1) Is the comma here correct/intended?
> 
>  $sfd{w} = $host_field->data(),;

That's certainly a typo.

> 
> FOR OTHER BUGS (if you want):
> 
> 1) I think we should adjust to also take RDA records using 264 into account
> here. At least for us these are now the majority of records.
> 
> +        # Publication
> +        if ( $host_field = $marc_host->field('260') ) {
> +            my $s = $host_field->as_string('abc');
> +            if ($s) {
> +                $sfd{d} = $s;
> +            }
> +        }
> 
> 
> 2) This should take $n$p into account as well, as otherwise a multi-part
> work will not be distinguishable from the title:
> 
> +        # Title
> +        if ( $host_field = $marc_host->field('245') ) {
> +            my $s = $host_field->as_string('ab');
> +            if ($s) {
> +                $sfd{t} = $s;
> +            }
> +        }

I'm more than happy to be guided on cataloguing standards.. I'm a mere dev
without enough real cataloging knowledge to get this 100% right without
guidance :)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to