https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37389
--- Comment #26 from Pedro Amorim <[email protected]> --- Hi guys, this is ready for review+testing. @Tomas @Liz are you available to test this with for the ILL use cases you were having issues with? Quite a lot of work went into this but the end code was actually not that extensive so I opted to squash and simplify the commit message to the best of my ability. I'm postponing applying this ExtendedAttributes Mixin to AdditionalFields classes for the following reasons: 1) No AdditionalFields classes use the extended_attributes as of yet (no performance issues there) 2) The key part that was missing here is actually already present in the additional_field_values accessors of the supporting classes, so no performance issue would happen there anyway 3) I'm considering this to be in the scope of bug 35287 as ERM Licenses will be the first AdditionalFields class to support the extended_attributes accessor, so I'm planning this work for when I rebase that. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
