https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37472
--- Comment #7 from Matt Blenkinsop <[email protected]> --- Thanks for taking a look! > I assume that the idea is to not copy the template files to a de-DE > directory, but handle all the translations on the fly. Is this correct? The translated template files are copied into a de-DE directory in the plugin directory rather than being added to all the existing core translated files. This is so that if a plugin is ever uninstalled it removes the translated files and they're not hanging around with the core templates. We use the de-DE directory that now sits in the plugin to substitute the translated templates, the same way as we do in core Koha > In that case I am not sure why an install translation step for plugins would > be needed, as I assume they would come with all available languages po files > as part of their source. What is achieved by installing a language for a > plugin? The plugins contain the po files but not the translated templates. The install step is needed to translate these using the core translation code, rather than needing to write translation code into the plugins themselves. It also takes any javascript strings and adds them to the existing javascript translations. (The plugin actually handles the translation step itself, see below) > Ideally I think if a language has been installed for staff or OPAC these > translations should be made automatically available when the plugin is > installed without requiring additional steps from server side. When a plugin is installed it won't require server side steps, it will trigger the translations during install (see below for the two plugin translation scenarios) > I am also not sure what is meant here: > > 13. We’ve proven the concept when installing a language with a plugin > already installed, we now need to prove the reverse i.e. that installing a > plugin on a system with languages already installed will update any existing > language translations > > I suspect I am missing something big here, please bear with me :) There are two key scenarios that could happen: 1) A plugin is already installed but no language has ever been installed on the system. When the language is installed, it needs to also account for any existing plugins that have appropriate translation files. This is the first half of the test plan up to step 13 2) A system already has additional languages installed and a new plugin is installed on the system that has translation files for those languages. The plugin installation needs to ensure that it is also translating itself to match the languages installed on the system. This is covered in the second half of the test plan when we uninstall the plugin and try re-installing it after we have installed a language on the system. In this scenario we don't need to run koha-translate on the system like you queried in your second question above as the plugin installation handles it for us Hope this all makes sense, let me know if you have any more questions! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
