https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

--- Comment #121 from Thibaud Guillot <[email protected]> ---
Hello 

Thank you for your very interesting feedback.. Indeed, integrating it directly
with get_effective_rule makes it possible to lighten the logic and not touch
the TooMany function in the way I did.. 
So I decided to draw up a new table in the "standard rules" section. He's going
to define maxissueqty and maxonsiteissueqty as "priority". 
These rules take over others less specific I think (but maybe I'm wrong) that
there is no need to define patron_maxissueqty and patron_maxonsiteissueqty in
this case.

The table is displayed as a reminder on the specific pages of each library but
hidden if no rules from this library are defined in the main matrix, and
displayed but not editable otherwise.

I have repeated this dev several times, normally I have not left too much trace
of the previous patches but if there is an error of logic forgive me I have had
my head upside down in the circulation rules lol.

I know that tests should be added but I already prefer to give you an overview
of the rendering if we go on this way.

Thank you for your feedback to everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to