https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36595
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #13 from Katrin Fischer <[email protected]> --- I see some small issues here. You don't check if the patron actually has an email set. The link will be broken if the email field is empty I believe. This will also not be translatable: ?subject=Hold item: [% itemsloo.title | uri %]"> I think when I looked at this trick in the past, there was also an issue with UTF8/diacritics. As you include the title, it might be worth testing with some Chinese or umlauts as these could happen to occur there. I don't thinks this should be a blocker here, but it might also be worth filing a separate bug for some template trick to show the email address according to EmailFieldPrimary and EmailFieldPrecedence. +1 for adding the class :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
