https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36027
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #28 from Katrin Fischer <[email protected]> --- I know that bug 36039 is blocked by this, but I'd like to ask some questions at least before pushing. 1) Quite a lot of untidyness added, please fix. WARN misc/maintenance/search_for_data_inconsistencies.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 83, now: 206) Can we fix this here or on the other bug? 2) New parameters (not blocker) I wonder if the chosen pattern is good as it requires that we add 2 new parameters for every check that we add to the script. We do have something similar in cleanup_database.pl for action logs and it seems more logical to me. --log-module Specify which action log modules to trim. Repeatable. --preserve-log Specify which action logs to exclude. Repeatable. --logs DAYS purge entries from action_logs older than DAYS days. Defaults to 180 days if no days specified. So instead of a unique parameter, you can use preserve-log with different codes. I am not sure what is better, just putting the question out here. 3) Script should not start without -c or any parameters... (not blocker) This is something for a separate bug. But we once said that scripts should output help when run without parameter and require a confirmation flag. As this can run quite a time, this still seems a good idea... (leaving this here for filing later) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
