https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31114
Pedro Amorim <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |m --- Comment #5 from Pedro Amorim <[email protected]> --- Hi, I've been taking a look here and this is my understanding: We want to hide the full record if no visible items match the branch filter criteria [correct me if I'm wrong please!]. The problem is, as Katrin said, the display/hiding of items is separate to the search filtering itself. This means that a search that returns 1 biblio with two items where first item is branch A and second item is branch B, it'll always return this record when filtering for branch:B, even if item B is hidden by OpacHiddenItems and only item A is shown. It's confusing because the patron filtered for B but is seeing a record only displaying one item for A. --------------------- I don't know what the immediate fix here could be, but I see a world where OpacHiddenItemsHidesRecord could be used here, since we want to hide the record based on OpacHiddenItems. Currently, OpacHiddenItemsHidesRecord hides the record only if all the items are hidden. We could add an additional logic rule to also hide the record if all displayed items don't match the 'branch:' filter. The problem with my proposed solution above is that OpacHiddenItemsHidesRecord is buggy and may cause more harm than good (see bug 35052), so unless bug 35052 progresses I don't see how we can reliably fix this. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
