https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31161
--- Comment #42 from Nick Clemens (kidclamp) <[email protected]> --- (In reply to David Cook from comment #38) > (In reply to Nick Clemens (kidclamp) from comment #37) > > We will clearly need tests here, however, the fact that we now respect > > OpacHiddenItems makes this a bit more urgent - in the past outside systems > > could use the filtering to determine if a record should be shown, > > essentially implementing their own OpacHiddenItems - but now the items don't > > come through and we cannot externally determine if a record truly has no > > items, or if all items have been hidden. > > > > Marking needs signoff as I need feedback on the approach and assumptions > > about following 'OpacHiddenItemHidesRecord' > > I think that I might like my approach better. If I understand this patch > correctly, if a record gets harvested by a consumer, then is hidden in Koha, > the record will just disappear from Koha's OAI-PMH interface, so it'll still > exist in the consumer. > > I should be able to look at my local code today, so I'll look at attaching > an alternate patch. (I'll also test this one, because maybe I am > misunderstanding this current patch.) Yeah, I had assumed if you change hiding rules you would want to do a reharvest to catch any that were hidden and no aren't, or vice versa. This actually makes me think the approach of storing the suppressed status at record edit (calculated via a background job) might be better - pre-calculating for search engine and OAI - really you could have OAI fetch via a scroll from ES - though not sure if ES supports resumption - ignore me, ranting I am not sold on these patches, I would love to see the direction you went, this was just the smallest cut along the lines of what you mentioned - determine when fetching record - it's like what we do in the opac - fetch from search engine, then filter. If you don't get to upload your patches I would still be interested just to hear how you approached it. I did consider here returning the hidden records as 'deleted'- it would have been even less code, but that felt like we still told them something was there - rather than full suppress the existence. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
