https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650
--- Comment #6 from Marcel de Rooy <[email protected]> --- Testing on master shows that the bug does not occur anymore after bug 34972. The call to CheckReserves seems to be wrong but this part of code does not seem to make any difference: if ( $userenv_branch ne $nextreservinfo->{'branchcode'} ) { my $patron = Koha::Patrons->find( $nextreservinfo->{'borrowernumber'} ); $template->param( itemtitle => $biblio->title, itembiblionumber => $biblio->biblionumber, iteminfo => $biblio->author, patron => $patron, diffbranch => 1, ); } If you confirmed a future hold, returns moves the hold to transit and creates a transfer now. The following call to CheckReserves will not find this hold, normally nothing. So $nextreserveinfo is expected to be undef. There is no additional display after the modal is gone. Just a checkin box. Warnings in the log confirm the uninitialized value: [2024/08/19 12:02:34] [WARN] Use of uninitialized value in string ne at /usr/share/koha/circ/returns.pl line 182. The master patch should resolve that warning now. And remove an additional one too on L253: [2024/08/19 12:04:01] [WARN] Use of uninitialized value $op in string eq at /usr/share/koha/circ/returns.pl line 253. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
