https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35905

--- Comment #5 from Brendan Lawlor <[email protected]> ---
(In reply to Katrin Fischer from comment #4)
> If I read this correctly, this seems not quite right:
> 
>     [% IF ( CAN_user_editcatalogue_edit_catalogue ||
> CAN_user_editcatalogue_edit_items ) %]
> 
> For "Edit record".
> 
> I believe the edit_items is not right here. The page seems only be
> accessible with either fast_cataloging or edit_catalogue. I think
> edit_catalogue is the one here.
> 
> Can you please revise?

Thanks Katrin!

You are right there is something off here. I think it may need some more logic
to handle all the different links that are automatically rendered in report
results. 

I added edit_items here for reports that have the itemnumber in them. Item
numbers link to /cataloguing/additem.pl?op=edititem&itemnumber=1 where i think
edit_items is maybe the least permission needed to access that page, but I'm
not sure if that's exactly correct either.

I just realized that the same issue exists for reports with brrowernumber or
cardnumber in them too.

It's been a while since I looked at this code in detail, but I will give it
another shot.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to