https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644
--- Comment #18 from Hammat wele <[email protected]> --- (In reply to Nick Clemens (kidclamp) from comment #13) > > t/db_dependent/Koha/ItemTypes.t: > 180 'Two item types with \'checkprevcheckout\' set to \'undef\' have been > added' > It's just the comment there ==> Fixed > > When editing an itemtype, it the system preference is 'soft' the options are: > Yes and try to override system preference > No and try to override system preference > Inherit from system preference > > From what I understand it does not 'try' to override, it always does > I think we should also display the system preference when set to 'Hard' > otherwise this can be a somewhat hidden feature ==> I removed the try in the options I don't think we should display the system preference when set to 'Hard' because when it's 'Hard' we can't get only two values "1" when it's hardyes and "0" when hardno, regardless of the value of "Check for previous checkouts:" > > For me, 4 nested 'map' calls is a bit obfuscated. Clearer would be something > like: > foreach my $syspref_setting ('hardno','hardyes','softno','softyes'){ > foreach my $itemtype_setting( 'inherit','no','yes'){ > ... > ==> Fixed > > t/db_dependent/Patron/Borrower_PrevCheckout.t > 49 itemtype => 'YESIT', > 59 itemtype => 'NOIT', > 69 itemtype => 'INHERITIT' > I just meant you don't need to specify the codes here, you use them later, > but could save the generated codes as variables in the hash and reference ==> Fixed we don't specify itemtype no more when creating a itemtype > It does, but it is inconsistent with how we handle this in Koha: > if( !column_exists( 'borrowers', 'middle_name' ) ) { ==> I updated the script by adding the condition to not add the column if it exists -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
