https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26777
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy |additional_work_needed, | |release-notes-needed --- Comment #63 from Katrin Fischer <[email protected]> --- Please verify my changes once pushed and reply to 1) :) 1) Naming and positioning This is a question: You named the tab "My virtual card", but that appears very general. What about we named it "Library card" or "Virtual library card" instead? Tbh I struggle a bit with the 'virtual and the "my" that we once had removed from all the other tabs. Also, right now the tab appears last in the patron's account, should we move it to be first or second? 2) Capitalization - My Virtual Card => My virtual card I've fixed this in a follow-up patch. 3) Translatability This is untranslatable: + document.getElementById('barcode-container').innerHTML = `<p><strong>Error: </strong>${errorMessage}</p>`; Also, strings should always be enclosed using double quotes. That's so that languages using single quotes like French don't break the JS by accident. See: JS2: Enabling translation of language strings in embedded JavaScript I attached a follow-up patch. 4) Missing CSS file This is not right, maybe related to the Bootstrap 5 change: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-virtual-card.tt: [% Asset.css("css/src/opac.css") | $raw %] This file doesn't exist. Updated to: css/opac.css in a follow-up patch. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
