https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36836
--- Comment #4 from Katrin Fischer <[email protected]> --- (In reply to Jonathan Druart from comment #3) > (In reply to Katrin Fischer from comment #2) > > There are some more issues I found but failed to fix. > > > > Maybe someone more knowledgeable about vue can help with these? > > > > > > 1) > > koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/ > > UsageStatisticsReportBuilder.vue > > > > All 4 alert(...) messages > > Try > this.$__("your string")) I already tried that I think and it didn't pick up the translations. I am a bit confused as to when to use what and mostly looked at other spots "similar" to what I was trying to do. Some notes on the wiki would be quite helpful. > > 2) > > koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/ > > UsageStatisticsDataProvidersCounterLogs.vue > > render: function (data, type, row, meta) { > > const importer = row.borrowernumber > > ? `<a > > href="/cgi-bin/koha/members/moremember.pl?borrowernumber=${row. > > borrowernumber}">Borrowernumber ${row.borrowernumber}</a>` > > : __("Cronjob") > > return importer > > }, > > > > I also suspect some other things to not translate, but might be easier to > > see in the GUI later and report separately. > > "Borrowernumber" won't be translatable I'd say. > > Try > "<a > href="/cgi-bin/koha/members/moremember.pl?borrowernumber=%s">%s</a>". > format(${row.borrowernumber}, __("Borrowernumber > %s").format(${row.borrowernumber})) > > But I am not sure we want to use "Borrowernumber" here... Similar for me, but I thought that could be a discussion for later. Maybe if this patch is OK we can move them to a separate bug for later, as I am not sure when I can work on the follow-up (already had this patch sitting for a few weeks). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
