https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37245
--- Comment #13 from Jonathan Druart <[email protected]> --- (In reply to Julian Maurice from comment #12) > (In reply to Jonathan Druart from comment #11) > > Not going further with this discussion. > I just wanted to point out that a rule cannot be enforced if it's not known > by everyone in the QA team. If the community agrees to enforce a rule it > should be written somewhere. Sorry for the grumpiness. Sometimes people are not around for discussion, and 1 or 2 people have to take quick decisions. At the time we had to deal with Vue, node_modules, etc. which was a huge task. We (at least Tomas, Martin and me regarding bug 32352 comments 4-6) decided to run the test suite on the files we knew that must be tested: the ones in Koha, ie. the ones in the git index. It seemed better than adding exceptions all over the xt files (see patch on bug 32352). Bug 33743 is also dealing with files we do not know that exists in the subdirs. how-to.tt: we know it is there, but others could be present for whatever reasons. > > Feel free to provide an alternative that works. > I would if you can tell me what's wrong about the patch. Several scripts in > xt/ use File::Find and it looks like they're working fine. They are wrong and should be adjusted IMO (using the same methods, `git ls-tree`). I just picked one randomly, xt/find-license-problems.t 36 unless $name =~ /\/(\.git|koha-tmpl|node_modules|swagger-ui)(\/.*)?$/ || This is not necessary if we were looping on `git ls-tree` output. We want the test suite to be run by different people and have the same result everywhere. If you have how-to.tt (that is not passing some tests), we don't care about it. If you have local files not in the git index, we don't care about them. We want the test suite to be as reliable as possible. I understand that we want more, and have the test suite to pass even if we are not within a git repo. But most importantly for me is to have consistency in the runs and easy reproducibility. Most of us are using ktd, and Jenkins is using it as well, which certainly covers more of 90% of the (dev) usages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
