https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37383
--- Comment #20 from Lucas Gass <[email protected]> --- (In reply to Jonathan Druart from comment #19) > I see, was it because we testing the holding library instead of the home > library? > > if ( can_edit_items_from[row.holding_library_id] ){ > > vs > > if ( can_edit_items_from[row.home_library_id] ){ Yes, the @libraries array was only returning home libraries, not holding. So that's why there was missing edit button for things that a librarian should have been able to edit. > If so, why didn't you simply adjusted the two lines in the template? Sorry for my ignorance, which 2 lines? > IIRC it seemed weird to pass an empty array if items from all libraries were > editable. Agreed, the empty array is weird but it's the solution I found. You should also look at Nick's Bug 37392. I am also happy to do additional work, or follow-up, if you think we could improve what we currently have. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
