https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37913
Bug ID: 37913
Summary: Remove more unreachable code in aqcontract.tt
Change sponsored?: ---
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P3
Component: Acquisitions
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Blocks: 37728
Bug 37823 removes one set of unreachable code from aqcontract.tt, a block that
tried to tell you that you had created a new contract rather than just showing
you the new contract, but there is another:
When you delete a contract, what actually happens is that you are shown the
details page for the vendor, which lists the contracts for that vendor at the
bottom, thus showing you that the contract has been deleted, but the template
has a block which thinks it is going to tell you "<h1>Contract deleted</h1>"
and then have you click an OK button to POST a form with no op param starting
with cud-, which now fails the CSRF protection. Luckily, it's unreachable (and
has been since aqcontract.pl first landed, it has always redirected after
deleting, and has never shown that block), but having it there still fails a
test once bug 37728 lands and lets the test see it.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37728
[Bug 37728] More "op" are missing in POSTed forms
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
