https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37930
--- Comment #7 from Matt Blenkinsop <[email protected]> --- (In reply to Jonathan Druart from comment #5) > I think we should keep one file per app. Otherwise we will end up with a big > ugly and hard-to-maintain authorisedValues/avMatrix.js. > > Why not simply have the av list in the store of the app (eg. stores/erm.js)? > > That would mean we could remove useAVStore and use the mainStore instead. We > would retrieve the AVs from the config: > this.config.avs.get("my_av") > this.config.avs.get_lib_from_av("my_av", value) > > Also for discussion :) I like the idea of using the module specific store so the new patch uses that methodology. I've opted not to include them in the config object as we overwrite that when we fetch the config and that wipes the existing authorised values we would have fetched Have a look at the patch above and see what you think - I've not changed all of the places we would need to remove the AV store yet as this may need changes and that would take time to keep repeating. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
