https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36049

--- Comment #18 from Raphael Straub <[email protected]> ---
(In reply to Katrin Fischer from comment #17)
> I'll have another look before pushing this as you are in principle right
> about adding inconsistencies. Maybe Raphael can weigh in here as he might
> have a better idea having looked at the code more closely?

To fix the whole problem, we would have to change every financial calculation
in Koha (in Perl and JavaScript, the database does it right) to use a decimal
datatype. I think it is not feasible to do it all at once. So, we should
identify isolated parts of Koha that could be fixed independently without
introducing new inconsistencies and fix those parts separately.

The patch in this bug fixes a rounding function that is used in several parts
of Koha and would introduce at least one inconsistency in the acquisition
module (see bug 37937). I would not push this patch until we think that no new
inconsistencies are introduced by it.

I wrote this bug report mainly to point out that there is a problem with
financial calculations in Koha and to provide an example of how this problem
can be solved.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to