https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37446
--- Comment #9 from Jonathan Druart <[email protected]> --- (In reply to Nick Clemens (kidclamp) from comment #7) > (In reply to Jonathan Druart from comment #6) > > Yes there is something wrong. The label should be adjusted for both, but we > > needed to take into account DisplayLibraryFacets to set facet_order to NUL > > if we didn't want to display it. > > > > Is that correct? > > The previous update doesn't seem to have touched facet_order: > vim installer/data/mysql/db_revs/231200036.pl > > If I understand, the changes in 35138 moved the control from the syspref to > the mappings - but existing mapping weren't touched, so libraries will now > ignore the syspref and display noth until mappings are altered. > > In either case, I think the only place the labels are used are int he facets > - so updating the labels to be correct no matter what shows does seem the > right thing to do Before bug 35138: DisplayLibraryFacets had priority over the settings in the mappings page. If you had DisplayLibraryFacets set to "holding library" (only) then only the holding library facet was displayed. In db_revs/231200036.pl we do not reorder the facet, and remove the facet_order for holding/homebranch when necessary. Not saying this patch is wrong, but there is still something wrong. Opened 37953, please test ASAP. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
