https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35369

--- Comment #6 from Victor Grousset/tuxayo <[email protected]> ---
Comment on attachment 165132
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165132
Bug 35369: SIP default 'Greetings from Koha.' message for patrons should be
optional and configurable

Review of attachment 165132:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=35369&attachment=165132)
-----------------------------------------------------------------

::: C4/SIP/ILS/Patron.pm
@@ +149,4 @@
>          fees            => 0,             # currently not distinct from fines
>          recall_overdue  => 0,
>          items_billed    => 0,
> +        screen_msg      => process_tt( 
> C4::Context->preference('SIP2ScreenMessageGreeting'), { borrower => $patron, 
> sip_borrower => $kp } ) . $kp->{opacnote} . $fines_msg,

How are `borrower => $patron, sip_borrower => $kp` used by process_tt() ?

It's not like SIP2ScreenMessageGreeting is supposed to contain TT syntax and
might need to use patron info. (I tried to put [% 'test' %] to double check and
it doesn't work)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to