http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18234|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <[email protected]> --- Created attachment 18236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18236&action=edit [PASSED QA] Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off Signed-off-by: Magnus Enger <[email protected]> I have failed to recreate the problem on three different dev installs, both on Ubuntu and Debian, but the current patch does not break anything as far as I can tell, so I'm signing off. I tested with two libraries in the same search domain, with each library owning a different book by the same author. Searching for the author in - all libraries, - individual libraries and - the search domain that contains both libraries all return the expected results. Signed-off-by: Katrin Fischer <[email protected]> All tests and QA script pass. I couldn't reproduce the problem, but didn't find any regressions. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
