https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37505
Emily Lamancusa <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Emily Lamancusa <[email protected]> --- (In reply to Nick Clemens (kidclamp) from comment #1) > It looks like bug 27992 added this information for all stats checkouts, then > 35950 changed it to only return the book if checked out. > > If we are to check in the book each time to show the messages I think we > need to add a way to skip the stats for return for each statistical checkout. This is a good point... I was thinking that the skip_localuse parameter would take care of this, but on testing, a return *and* a localuse are in fact both getting recorded, even if the item was not checked out in the first place. The problem seems to be coming from these lines in AddReturn: 2168 if ( C4::Context->preference("RecordLocalUseOnReturn") ) { 2169 $localuse_count++; 2170 $item->localuse($localuse_count)->store; 2171 $messages->{'LocalUse'} = 1; 2172 $stat_type = 'localuse'; 2173 } and 2459 C4::Stats::UpdateStats({ ... 2469 }) unless ( $skip_localuse && $stat_type eq 'localuse' ); That being said, if RecordLocalUseOnReturn is off, and someone checks in an item that was not checked out, it adds a return stat also. Is that a desired behavior, or can we fix two bugs at once by simply telling AddReturn to never add a 'return' stat if there was no checkout? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
