https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36435
Michał <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Michał <[email protected]> --- I agree. This is the better approach, as the function won't return an error on a harmless warning, plus its remainder will continue to run, including the chmod+chown invokations afterwards, which is intended. If there's an actual error from tar (error code different than 0 or 1), the function will return early and then deleting old files will be blocked like previously, which is also still good behavior (since an actual error could mean no backup was made, and thus all good backups would be deleted otherwise). Turning the status back to Signed Off then, the patch contents themselves haven't changed (including the existing Signed Off), other than removing "[alternative]" from the Subject title. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
