https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28657
Michael Hafen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172149|0 |1 is obsolete| | --- Comment #25 from Michael Hafen <[email protected]> --- Created attachment 172197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172197&action=edit Bug 28657: expand branches.branchip to allow for multiple ip ranges. . Change branches.branchip to a mediumtext, and remove '*' from existing branchip settings. . Change C4/Auth.pm and Koha/Template/Plugin/Branches.pm from a regexp to using in_iprange() to check client address against branchip. (in_iprange() doesn't work with '*' in branchip.) . Change in_iprange() to default to false (which is what the POD says it should do). Also, have it trim '*' in case someone adds some back later. . Change note in admin/branches.tt under branchip field to reflect changes to branchip handling. Test plan: 1. Turn on StaffLoginRestrictLibraryByIp or StaffLoginBranchBasedOnIP system preference 2. Change a libraries branchip to multiple ip ranges seperated by a space, making sure one of the ranges includes your computers address. 3. Log out and try logging in. The library won't appear in the select list. The location check will fail. 4. Apply patch and database update in patch. Restart plack if necessary. 5. Try logging in again. The library will appear in the select list and the location check will succeed. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
