https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856
--- Comment #31 from Pedro Amorim <[email protected]> --- Created attachment 172215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172215&action=edit Bug 37856: Update atomicupdate messages (In reply to Katrin Fischer from comment #25) > The way the database update outputs messages is a bit non-standard. I fixed > the messages (we are not mentioning the bug number every time for example), > but I didn't change the structure. > I think what it should have done was printing different messages in case of > the column already existing or not, but the "Done" seems not quite right. > Not terribly important overall, just noting for future. (In reply to Jonathan Druart from comment #30) > 19 say_success( $out, "Done" ); > > Is this expected? "Done"? The original patch: https://github.com/Koha-Community/Koha/commit/2e4b1ca42f7a940e8329ed860dda102deb629db0#diff-661419b80761834f79ce9100a1f2a132b804ee7cdf4efffe14c29d93bec810e4R17 Had: say_success( $out, "Bug 37856 - Done" ); I wanted to provide indication that the update of that particular bug was done, regardless if a change on the database happened or not. This is clearly causing confusion, this is now showing messages more in line with standard I believe. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
