https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36171
--- Comment #34 from Victor Grousset/tuxayo <[email protected]> --- Tested on 23.05 to get the two observed cases of extracted strings that can break the UI (I also applied the test plan there): #~ msgid "%s %s %s [%%~ SET line_break = \"" It's successfully not picked anymore. That solves 70% of the found cases of translations breaking pages. It's still picking up this: #: koha-tmpl/intranet-tmpl/prog/en/includes/country-list.inc:1 #, c-format msgid "[%% SET countries = [ \"Afghanistan\", \"Albania\", \"Algeria\", [...] Which allows translation of country name in Koha <= 23.05 (before bug 35091) But it's picked in it's entirety. So with "countries" which was the cause of breakage when it's translated.(30% of the observed breakages) If it would somehow be done differently, then the string would change to not have "countries". But then the whole list would have to be retranslated for old releases which might not have much translation attention. Which is the same downside with a less good result than backporting bug 35091. So not much do to for these cases. Not and issue for this ticket. --- More testing: Looking at the extracted string changes, there are more strings that are not extracted anymore. -msgid "%s %s %s %s %s %s %s %s %s %s %s%s %s %s %s %s [%% # [ WRAPPER tab_item tabname= \"tab_name_1\" bt_active= 1 ] " -msgid "[ END ] %%] %s %s %s %s %s %s %s %s %s %s " -msgid "%s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s %s%s%s %s %s %s %s %s [%%- span_start = '" -msgid "[%% HOLIDAYS_LOO.DESCRIPTION.replace('\\\\\\r\\\\\\n', '" [... other stuff] Nice, good riddance :) --- [% # [ WRAPPER tab_item tabname= "tab_name_1" bt_active= 1 ] <span>Tab text 1</span> [ END ] %] [% # [ WRAPPER tab_item tabname= "tab_name_2" ] <span>Tab text 2</span> [ END ] %] [% # <a href="/cgi-bin/koha/module/module-home.pl"> Module </a> %] [% # <a href="/cgi-bin/koha/module/page.pl"> Module page </a> %] [% # <span>Module page</span> %] [% # <span>Add form</span> %] Very good! This stuff that was in comments isn't picked up anymore! :D --- -msgid "%s [%% SET pref_CurbsidePickup_link = '" -msgid "%s %s [%% SET pref_MARCOverlayRules_link = '" Nice, it takes care of these cases that were identified as maybe being a pain! :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
