https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149
--- Comment #3 from Victor Grousset/tuxayo <[email protected]> --- This is the 2nd time I'm really messing with node stuff so I don't know what I'm doing.🙃 Don't trust anything you see! The process was throwing things at the wall and see what stuck. 🫠I don't know if there aren't too much changes in lock files. I did `yarn add prettier eslint --dev` And `yarn upgrade eslint-plugin-prettier` (I think) so package.json still has the old version but the lock has the latest so it's fine. But I don't know if package.json should still be manually updated. ---- Some things I did to double check stuff: Before applying the test plan, deleting the node_modules directory. To avoid keep manually installed stuff and wrongly thinking things worked. .eslintrc.json + ], + "prettier/prettier": [ + "error" Sabotaged one and then the other of these lines and see that it errors to confirm it's not dead config. "extends": [ "eslint:recommended", - "prettier" + "eslint-config-prettier" + ], + "plugins": [ + "eslint-plugin-prettier" Same here. ------- Next steps after this: 1. Migrate to the flat config file to avoid having that ugly ESLINT_USE_FLAT_CONFIG='false' 2. Add the necessary stuff to be able to use ESLint on .vue and .ts files. 3. Open a ticket in QA tools (try to implement, at least partially) about having the same check with ESLint as we have with perltidy. (comparing number of messy line before and after the patches) 4. ???? 5. PROFIT!!! (Finally JS8 will be fully and easily checkable!!!!! :D) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
