https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355
--- Comment #77 from Matt Blenkinsop <[email protected]> --- (In reply to Nick Clemens (kidclamp) from comment #63) > Doubled pref in patches: > pref: SerialsDefaultReplyTo > looks like rebase issues Corrected > A user can CRUD Marc Order Accounts with only catalogue permissions - I > think it needs to be a new subpermission of acquisitions Added a new permission marc_order_manage > A full search of vendors is used on the marc order accounts page - this > should be a select2 and not load all into template (we have partners with > thousands of vendors) Migrated to kohaSelect > create_items is not set for basket - I think 'ordering' is required? maybe > this setting is just ignored for this process? I think we should set it - I've amended it to be set > you mention _stage_file is a clone from the background job. it should be > moved into a place that can be shared with the background job to dry the code Done - moved to Koha::ImportBatch > match_file_to_account - POD should indicate only the first record is checked > on the account page it should specify the format, dollar sign for subfields, > i.e. 245$a Done > Commit titles below don't match the patches, can you explain? > Bug 34355: Make item addition dependent on MarcItemFieldsToOrder mappings > and introduce MarcFieldsToOrder to cronjob > Bug 34355: Add a plugin hook - before_orderline_create I think this is the result of rebases - the plugin hook had been lost and is now restored. The other commit I have squashed as it is no longer necessary as a separate commit as the history has been broken by other squashes/rebases > koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_order_accounts.tt > The selected option choices are split by the conditionals, include the full > option selected or not > You remove the use of tools-overlay-action.inc / tools-nomatch-action / > tools-item-action - I think we should keep this to not repeat - the > selection variables lok unsused so can be updated to work with > the data here (e.g. git grep overlay_action_replace ) Amended the templates to reflect this > Warning when processing test file: > Use of uninitialized value in concatenation (.) or string at > /usr/share/perl5/MARC/File/XML.pm line 399, <__ANONIO__> chunk 5. > Maybe a data problem with the file? This comes from the MARC library we import from CPAN and happens with the file when running a normal staged import > The cronjob deletes the file - I think we want an option to rename/move the > file, rather than full deletion - if something is wrong, we want the file > for reference I've added a delete flag - if this isn't set the cronjob now moves processed files to an 'archived' folder > It looks like a few fields were not included in > _create_item_fields_from_syspref: > coded_location_qualifier, barcode, and enumchron - special field quantity Updated -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
