https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38148

--- Comment #7 from Pedro Amorim <[email protected]> ---
Created attachment 173125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173125&action=edit
Bug 38148: Revert back to get_effective_rule

And update the first conditional logic.
This patch aims to maintain the logic behind the first patch, but restore
get_effective_rule.
get_effective_rule_value is using cache and I believe that is the reason why
Items.t fail when using that.

Test plan:
1) Search for 'music' on OPAC
2) Notice records have the 'place hold' link
3) Visit circulation rules on Staff:
<staff_url>/cgi-bin/koha/admin/smart-rules.pl
4) On 'Default checkout, hold and return policy' , under 'Hold policy' pick
'From any library'. Hit 'Save'.
5) Repeat 1). Notice the 'place hold' link is gone.
6) Apply patch. restart plack. Repeat 1). Notice the 'place hold' is shown
again

Run:
$ prove t/db_dependent/Koha/Items.t

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to