https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38175

Martin Renvoize (ashimema) <martin.renvo...@ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #172884|0                           |1
        is obsolete|                            |

--- Comment #21 from Martin Renvoize (ashimema) 
<martin.renvo...@ptfs-europe.com> ---
Created attachment 173176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173176&action=edit
Bug 38175: (QA follow-up) DRY out PATCH handling

We were repeating some code for the PATCH endpoint instead of using the
existing update handling code.  This lead to two issues:

1) We weren't catching status updates on standard updates, only the
   patch.
2) We were limiting the PATCH endpoint to just status updates when it
   could happily be used for other fields too.

This patch removes the introduction of the 'edit' method from both the
REST controller and the corresponding object and moves the logic into
the store method of the object where it's easily testable.

We also DRY out the notice sending code a little for re-use.

Signed-off-by: Martin Renvoize <martin.renvo...@ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to