https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38235

            Bug ID: 38235
           Summary: Suggestion confirmation letter sent when it should not
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]

When processing a new order (creating basket, receiving order, etc.) using a
bibliographic record once already linked to an old suggestion (already
completed in the past), Koha generates and sends a confirmation letter that
should not be sent at all.

This is because suggestions in Koha are linked to a biblionumber (and not the
order), and so the old suggestion is identified - erroneously - as relevant. 
Then C4::Suggestions::ModSuggestion sends a letter whenever it receives STATUS
as a parameter, paying no attention to whether the status is changed.  So, in
this case, a suggestion already in the status AVAILABLE is "updated" to the
status AVAILABLE and the letter is generated.  To solve this problem, it should
be enough to check whether STATUS is actually changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to