https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295

Katrin Fischer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|no-sandbox                  |additional_work_needed,
                   |                            |release-notes-needed

--- Comment #30 from Katrin Fischer <[email protected]> ---
I've reviewed the code and the test plan and found some things:

1) Configuration (question)

get_failed_notices takes days as a parameter, but it's always used with the
default (7) or explicitly with 7. 

So it will always check all notices sent in the last 7 days.

Should we include a note in the system preference about this timeframe?


2) Terminology (solved)

say "There are borrowers with failed SMS or email notices" if $verbose;

borrowers => patrons

Fixed in follow-up.


3) Database update (for future reference)

Please submit database updates in a single atomicupdate file (less work for RM
who has to combine them manually).

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to