https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37639

--- Comment #33 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
Lucas, I think there's been some miscommunication regarding this comment:

(In reply to Marcel de Rooy from comment #9)
> Just feeling that it would be better to list it (skip 2nd patch).
> Also note:
>         withdrawn                => 'withdrawn',
>         timestamp                => 'timestamp',
>         location                 => 'location',
>         uri                      => 'uri',
> 
> Is it possible to add a tiny test to prove the result of this change?

We never add tests for `to_api_mapping()` and my interpretation of Marcel's
comment is that he doubts we need those specific mappings (which are dated a
few years ago). I think we need to remove the tests and squash the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to