https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38020
Pedro Amorim <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |m --- Comment #4 from Pedro Amorim <[email protected]> --- I don't think this is PQA ready but don't think the reasons below are enough to FQA either, so I'm only leaving comments here in case they make sense: 1) The following code: $(".delete-list").click(function(e){ return confirm(_("Are you sure you want to delete this list?")); }); in virtualshelves/shelves.tt is no longer used after this patch, because the confirmation message is now part of the anchor link. If this is true, it should be removed. 2) Not related to this patch directly, but related to the previous point, virtualshelves/tables/shelves_results.tt has 'class="delete-list' for the delete button on the list view, but the JS code in 1) is only used on the 'view' op, not the 'list' op, thus deleting a list from the detail page has a confirmation dialog, but deleting a list from the list view does not have a confirmation dialog. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
