https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37050
--- Comment #24 from Brendan Lawlor <[email protected]> --- Hi Pedro, thanks for finding these issues! (In reply to Pedro Amorim from comment #23) > Observations: > It feels a bit weird to allow for an empty selection (causing an empty box > with an x), and have that empty option behave the same as if no option was > selected at all. Should we just not show an empty option in this case? The > user can deselect any selections and submit it empty anyway. I hadn't noticed that the hidden select option is selectable in the select2 dropdown. I agree this should be fixed. It seems to be that select2 is not respecting the hidden property on that first option for some reason. > Found the following error: > A) Follow steps 1 and 2 of the test plan, submit the empty form -> all good > B) Follow steps 1 and 2 of the test plan, pick a single library, then > remove, submit the empty form -> BOOM The template fills all the codes into the hidden option and then every time the user updates selections the value of the hidden option is updated. This error is happening because of an edge case when everything is deselected the value is becoming an empty string when it should revert to a newline delimited list of all codes. I will come back to this and submit a new patch as soon as I can. Thanks! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
