https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #141 from Katrin Fischer <[email protected]> --- There are some issues here that will require follow-ups: 1) Translatability a) Using __() in a .pm (nothing to do here) I am glad I double checked these, because I thought they would not work, but they do get parsed into the po files. Koha/ILL/Backend/Standard.pm + name => __('Switched provider'), + ui_method_name => __('Switch provider'), b) But this... hm: + # FIXME: This should all be made translatable as is basically a + # code => description mapping. The metadata() sub is using this + # descriptions as keys. I thought this was a bug on this backend + # but it turns out opac-illrequests.tt is using those descriptions + # as keys. for example: c) JS (definitely needs fixing): + '</span>Delete</button></li>'; 2) Unused variables (to fix, see QA script complaint): + my $marc_isbn; + my $marc_author; + my $marc_title; 3) Terminology (please fix) +<p><em>Please Note:</em> Branch is a mandatory field.</p> +[% ELSIF whole.status == 'invalid_borrower' %] +<p><em>Please Note:</em> The borrower details you entered are invalid.</p> +[% ELSIF whole.status == 'invalid_branch' %] +<p><em>Please Note:</em> The branch you chose is invalid.</p> +[% ELSE %] This repeats in several files, where the field itself has already been renamed to "Destination library". branch => library + <label class="required" for="brw">Borrower</label> Borrower => Patron 4) Database update (fixed) a) No need to repeat the bug number for each message, it will be at the beginning of the paragraph. + "Bug 35570: Updated ILL request attributes from 'FreeForm' to 'Standard'" I removed these when moving the database update to dbrevs. b) Can you explain this one? The English strings make me a little suspicious (question) + my $reports = join( + "\n", + map( "\tReport ID: " + . $_->id + . ' | Edit link: ' + . C4::Context->preference('staffClientBaseURL') + . '/cgi-bin/koha/reports/guided_reports.pl?reports=' + . $_->id + . "&phase=Edit%20SQL", + Koha::Reports->search( { savedsql => { -like => "%FreeForm%" } } )->as_list ) + ); 5) Wrong version (fixed) + <p>All 'FreeForm' ILL content should've been migrated to 'Standard' upon upgrading Koha to 24.05.</p> Changed to 24.11 in follow-up. 6) Unit tests (separate bug?) There are no unit tests, but it feels like there should be some... Maybe for a separate bug at this point. 7) Styling (separate bug) Some of the pages and elements in the forms have unusual styling. For example we are missing the "yellow" buttons for the main actions. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
