https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269
--- Comment #13 from Johanna Räisä <[email protected]> --- (In reply to Pedro Amorim from comment #12) > This is really impressive work. It works great from what I can tell. > I have some observations, though I don't think any one in particular is a > blocker, and some may not need a follow-up and are simply observations: > > - Entering an expiration date triggers the same API call twice > - Entering "suspend on" date triggers the same API call twice > - Date inputs are missing the "x" to clear the input > - Entering "suspend on" date immediately suspends the hold. On the previous > table you'd have to click the 'suspend' button after inserting the date to > effectively suspend it. > - The label for a suspended hold is "Resume", previously was "Unsuspend". > - Trash icon for "delete" icon missing hover pointer cursor. > - If all actions now update holds in real-time, do we still need the "Update > hold(s)" button at the top? Previously this was needed to save the changes, > but it's not anymore. > - "Print slip" button now always shows, previously it only showed if > hold.intransit || hold.atdestination. > - Deleting a hold is triggering table redraw API call multiple times, to > reproduce: > -- Place 3 or 4 holds on a patron. > -- Move the priority around multiple times for all holds. > -- Delete one of the holds. > -- Notice the network tab calling the same API endpoint multiple times > (sometimes over 10 times) > > I think at least the "Update holds" button question and the multiple API > calls issues should be addressed. What do you think Johanna? Do you agree? > Up to you how best we should follow-up here. I think this is really good as > is already. Thank you for reviewing, this was a big one! I totally agree with you. We don't actually need the "Update hold(s)" button anymore, I doubted it while I was doing it. Good to hear that you think the same. I will optimize those API calls and improve other features as well. Good to get some other to look at this. I was getting blind to all these features. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
