https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37895
--- Comment #25 from Jonathan Druart <[email protected]> --- Also some (all?) say_failure statements will never been reached as DBI has RaiseError turned on, so installer/data/mysql/db_revs/240600029.pl 34 if ( $dbh->do("$creation_date_statement AFTER `end_date`") ) { 35 say_success( $out, q{Added column 'bookings.creation_date'} ); 36 } else { 37 say_failure( $out, q{Failed to add column 'bookings.creation_date': } . $dbh->errstr ); 38 } This is useless code if not better written (with try-catch + rethrow). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
