https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38287
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Katrin Fischer <[email protected]> --- (In reply to Pedro Amorim from comment #8) > (In reply to Katrin Fischer from comment #7) > > I wonder if we are quite there yet here. I had added a rule leaving one > > field empty, but now the tests fail. Can you please check, Martin? Maybe > > there is more needed here. > > > > # Failed test 'Koha::Item->find_booking returns undefined when the > > current booking is cancelled and the future booking is out of range' > > # at /kohadevbox/koha/t/db_dependent/Koha/Item.t line 3022. > > # got: 'Koha::Booking=HASH(0x55691b45d918)' > > # expected: undef > > > > # Failed test 'Koha::Item->find_booking returns undefined when the > > current booking is deleted and the future booking is out of range and > > there's no lead period rule' > > # at /kohadevbox/koha/t/db_dependent/Koha/Item.t line 3040. > > # got: 'Koha::Booking=HASH(0x55691b30fc00)' > > # expected: undef > > # Looks like you failed 1 test of 3. > > > > # Failed test 'Preparation period handling' > > # at /kohadevbox/koha/t/db_dependent/Koha/Item.t line 3074. > > # Looks like you failed 2 tests of 8. > > This does not seem related. Tests pass for me before and applying the > patches here. You need to add data, not just run the tests. With the patch applied, add a rule that leaves these fields empty. Before the patch, the rule would not save, but now it does. Run the test after. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
